devguide icon indicating copy to clipboard operation
devguide copied to clipboard
verified publisher icon python

There is a "TODO" in the Setup-building.rst

Open Mariatta opened this issue 1 year ago • 1 comments

I noticed a TODO in the setup-building.rst page.

.. TODO: add docker instructions

Are we still planning to complete this? If not, can we remove it?

Action items:

  • Either remove the todo
  • Or complete the todo

Mariatta avatar Sep 24 '24 01:09 Mariatta

@marlenezw you added the TODO item here a year ago. Any updates? Is this still needed? If so, what is needed to complete this todo item?

Mariatta avatar Sep 24 '24 20:09 Mariatta

@Mariatta, I was browsing through issues and saw that this TODO was removed and replaced with instructions on running the container in this commit: https://github.com/python/devguide/commit/8b085665d9694d7ce4cf8ed0f231888fbf60dff8 associated with https://github.com/python/devguide/pull/1568.

Should be good to close this issue?

josephgruber avatar Sep 07 '25 18:09 josephgruber

Yes it has been completed, but It was done in https://github.com/python/devguide/commit/aaa8d72adaab1698105bde70aecf8c18c240ba96.

cc @encukou

StanFromIreland avatar Sep 07 '25 19:09 StanFromIreland