cpython
cpython copied to clipboard
gh-96250: Improve sqlite3 injection attack example
- Issue: gh-96250
Thanks so much, Jia! I've taken the liberty to reflowing the comment because of the 79 char limit; hope you don't mind.
Minor sidenote, but it looks a little strange to me to enter comments at the interactive prompt. Maybe just enter them without the prompt, since they should still be displayed as "output" and don't really need to be shown when clicking the >>>
button to show only copyable code, no?
Minor sidenote, but it looks a little strange to me to enter comments at the interactive prompt. Maybe just enter them without the prompt, since they should still be displayed as "output" and don't really need to be shown when clicking the
>>>
button to show only copyable code, no?
Even better, make them part of the prose.
@jiajunjie, ping me when you've addressed the review remarks :)
Thanks @jiajunjie for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. 🐍🍒⛏🤖
GH-100119 is a backport of this pull request to the 3.11 branch.
GH-100120 is a backport of this pull request to the 3.10 branch.