cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-96250: Improve sqlite3 injection attack example

Open jiajunjie opened this issue 2 years ago • 1 comments

  • Issue: gh-96250

jiajunjie avatar Nov 09 '22 01:11 jiajunjie

Thanks so much, Jia! I've taken the liberty to reflowing the comment because of the 79 char limit; hope you don't mind.

erlend-aasland avatar Nov 09 '22 12:11 erlend-aasland

Minor sidenote, but it looks a little strange to me to enter comments at the interactive prompt. Maybe just enter them without the prompt, since they should still be displayed as "output" and don't really need to be shown when clicking the >>> button to show only copyable code, no?

CAM-Gerlach avatar Nov 16 '22 04:11 CAM-Gerlach

Minor sidenote, but it looks a little strange to me to enter comments at the interactive prompt. Maybe just enter them without the prompt, since they should still be displayed as "output" and don't really need to be shown when clicking the >>> button to show only copyable code, no?

Even better, make them part of the prose.

erlend-aasland avatar Nov 16 '22 08:11 erlend-aasland

@jiajunjie, ping me when you've addressed the review remarks :)

erlend-aasland avatar Nov 24 '22 11:11 erlend-aasland

Thanks @jiajunjie for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. 🐍🍒⛏🤖

miss-islington avatar Dec 08 '22 20:12 miss-islington

GH-100119 is a backport of this pull request to the 3.11 branch.

bedevere-bot avatar Dec 08 '22 20:12 bedevere-bot

GH-100120 is a backport of this pull request to the 3.10 branch.

bedevere-bot avatar Dec 08 '22 20:12 bedevere-bot