cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-64490: Fix refcount error when arguments are packed to tuple in argument clinic

Open colorfulappl opened this issue 3 years ago • 1 comments

While Argument Clinic generated code is packing varargs to a tuple, the arguments' refcounts are not increased. So all the packed arguments‘ refcounts are decreased 1 improperly when the tuple is released later.

This bug is found in https://github.com/python/cpython/pull/96178 "Argument Clinic functional test".

  • Issue: gh-64490

colorfulappl avatar Nov 08 '22 03:11 colorfulappl

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Nov 08 '22 03:11 bedevere-bot

Added Argument Clinic functional test (#96002). @erlend-aasland @kumaraditya303

colorfulappl avatar Nov 24 '22 07:11 colorfulappl

Merged, thanks!

kumaraditya303 avatar Nov 24 '22 12:11 kumaraditya303

Thank you!

colorfulappl avatar Nov 24 '22 13:11 colorfulappl

GH-100338 is a backport of this pull request to the 3.11 branch.

bedevere-bot avatar Dec 19 '22 03:12 bedevere-bot