cpython icon indicating copy to clipboard operation
cpython copied to clipboard

[3.8] gh-98433: Fix quadratic time idna decoding. (GH-99092) (GH-99222)

Open miss-islington opened this issue 3 years ago • 2 comments

There was an unnecessary quadratic loop in idna decoding. This restores the behavior to linear.

(cherry picked from commit d315722564927c7202dd6e111dc79eaf14240b0d)

(cherry picked from commit a6f6c3a3d6f2b580f2d87885c9b8a9350ad7bf15)

Co-authored-by: Miss Islington (bot) [email protected] Co-authored-by: Gregory P. Smith [email protected]

  • Issue: gh-98433

miss-islington avatar Nov 08 '22 02:11 miss-islington

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

miss-islington avatar Nov 08 '22 03:11 miss-islington

@ambv: Would you mind to merge this security fix? It's already in other branches, including 3.7 ;-)

vstinner avatar Nov 09 '22 10:11 vstinner

@ambv : is there a plan for when the next 3.8 release might be cut? I noticed that this item wasn't in .15; Blackduck is already citing this as an issue, so the need for resolving this in cpython and trickling the fix down will need to come sooner rather than later.

ngie-eign avatar Nov 15 '22 20:11 ngie-eign

Release manager conversations recently suggest they'll be coordinating releases for the week of December 5th.

gpshead avatar Nov 15 '22 20:11 gpshead