cpython
cpython copied to clipboard
python
GH-91375: Port `_asyncio` static types to heap types and module state
:robot: New build scheduled with the buildbot fleet by @kumaraditya303 for commit 83d1b5434fec3e4d2c6196d58b6ec85bd9983c21 :robot:
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
:robot: New build scheduled with the buildbot fleet by @kumaraditya303 for commit 83d1b5434fec3e4d2c6196d58b6ec85bd9983c21 :robot:
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
:robot: New build scheduled with the buildbot fleet by @kumaraditya303 for commit ac753f3824aa9fdfc8e3b677c39eee44803f3785 :robot:
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
We should be able to get rid of module_initialized now that we've got multi-phase init. Also, the module_free(NULL) at the end of module_init() should now be removed.
Yes, I thought I had done that but apparently not, might have been messed up in rebasing. Fixed now.
Kumar: Do you think there's a chance of getting one of the other core devs to do a review? (Andrew or maybe Eric?)
Do you think there's a chance of getting one of the other core devs to do a review? (Andrew or maybe Eric?)
Andrew is not active ATM because of the war, Eric is busy with the other stuff so I don't think he will have time for this.
Andrew is not active ATM because of the war, Eric is busy with the other stuff so I don't think he will have time for this.
Yeah, I feared that.
Do you have a chance to check if there's a performance hit? (I'd be very surprised if there is one.)
I'm going to take a look, but it might not be immediately.
Great, thanks!
However, there's a merge conflict that needs to be resolved first...
Fixed merge conflict.
Most of the changes are trivial stuff like passing the module state around to various support and helper functions.
I am thinking of merging this by next week so that it gets in the next alpha. @ericsnowcurrently If you are not able to review by then, I can do a follow up PR for your review if that's okay with you.