cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-98250: Improve documentation about change to Enum.__format__

Open mdboom opened this issue 3 years ago • 1 comments

  • Issue: gh-98250

mdboom avatar Oct 14 '22 14:10 mdboom

Hey, I missed seeing this before I submitted #98295 , but it turns out I noticed a similar issue, as the What's New was not entirely clear on that point, and had already made some enhancements in that regard. I went ahead and made some further improvements and expansions there to more comprehensively address #98250 and incorporate the intent of the changes here, alongside @JelleZijlstra 's suggestion and a number of additional fixes and clarifications.

As that PR essentially rewrites that section and will thus conflict with this one, which I'm still not sure is quite right (as ReprEnum appears to do something quite different from the old __format__ behavior, and there are also still a few smaller points of confusion here), my suggestion would be to consolidate on that one (especially since we don't have much time left before the release), and I'd welcome your review and suggestions over there.

CAM-Gerlach avatar Oct 15 '22 23:10 CAM-Gerlach

Closing in favor of the more comprehensive #98295.

mdboom avatar Oct 17 '22 13:10 mdboom