cpython icon indicating copy to clipboard operation
cpython copied to clipboard
Published 4 days ago • verified publisher icon python

gh-98086: Now ``patch.dict`` can decorate async functions

Open sobolevn opened this issue 3 years ago • 4 comments

I will check other patch.* types for similar problems in the next issues / PRs.

Issue: gh-98086

sobolevn avatar Oct 08 '22 16:10 sobolevn

@sobolevn Will these changes be considered for backports to earlier Python versions?

I'm asking, because I'm trying to assess if pytest-asyncio needs to provide a workaround.

seifertm avatar Oct 21 '22 10:10 seifertm

This looks like a bugfix to me. So, according to the regular policy: yes, they will be. But, there might be exceptions. Let's wait for the code owner :)

sobolevn avatar Oct 21 '22 10:10 sobolevn

@cjw296 friendly ping :)

sobolevn avatar Nov 07 '22 08:11 sobolevn

I'm afraid I don't have time to review this right now. @tirkarthi / @mariocj89 ?

@seifertm - even if merged, this will only be backported to 3.11 and 3.10.

cjw296 avatar Nov 07 '22 17:11 cjw296

Thanks @sobolevn for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. 🐍🍒⛏🤖

miss-islington avatar Nov 11 '22 09:11 miss-islington

Thanks @sobolevn for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. 🐍🍒⛏🤖

miss-islington avatar Nov 11 '22 09:11 miss-islington

GH-99365 is a backport of this pull request to the 3.11 branch.

bedevere-bot avatar Nov 11 '22 09:11 bedevere-bot

Thanks everyone, I've scheduled 3.10 and 3.11 backports

sobolevn avatar Nov 11 '22 09:11 sobolevn