python
gh-98040: Remove find_loader, find_module and other deprecated APIs
Still lots of test failures and probably more things to remove, but it's a start!
@brettcannon @ericsnowcurrently Well, this branch is already getting pretty big. Pull a thread, unravel a sweater. There's still some things to do (see the ticket), but it's not too late to provide feedback. I was pretty aggressive in removing things that seemed to be obsolete or testing obsolete APIs, so hopefully I wasn't too eager to remove things. Feedback welcome!
Should this PR be a draft until the tests are passing?
Yes, done. The blocker is being worked on upstream so I think pip 23.0 will likely unblock this PR. In the meantime, I'll keep the branch clean as is.
Well, this branch is already getting pretty big. Pull a thread, unravel a sweater.
How much work would it be to move the imp removal to a separate PR? If a lot, don't worry about it. Either way, I am planning on reviewing these changes.
How much work would it be to move the imp removal to a separate PR? If a lot, don't worry about it. Either way, I am planning on reviewing these changes.
It was kind of tricky, but let me take another look. I agree it would be better to split these into smaller PRs.
Thanks for taking another look! I know what a pain it can be to split up a big PR.
This branch is close enough now that I'll move it out of draft. @ericsnowcurrently and @brettcannon It's probably ready for review soon.
Would you be happy for me to push to this branch with said docs cross-referencing changes?
Yes, this would be very helpful, thanks.
