cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-95736: Fix event loop creation in IsolatedAsyncioTestCase

Open serhiy-storchaka opened this issue 3 years ago • 5 comments

It should be created before calling the setUp() method, but after checking for skipping a test.

  • Issue: gh-95736

serhiy-storchaka avatar Aug 16 '22 19:08 serhiy-storchaka

:robot: New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 1194f25ded04a15a1a5ec408ce81178e24125c20 :robot:

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot avatar Aug 16 '22 19:08 bedevere-bot

I have a new ticket and PR GH-96031

tiran avatar Aug 16 '22 19:08 tiran

Well, this fix sure looks simpler than @tiran's. I'll defer judgment until I've had time to look at things more thoroughly though.

gvanrossum avatar Aug 16 '22 20:08 gvanrossum

Let's merge this PR to unblock and fix main branch. We can solve https://github.com/python/cpython/issues/95736 and correct the problematic implementation in the async unittest helper later.

tiran avatar Aug 16 '22 20:08 tiran

The wasm32-wasi PR build fails with a different error:

======================================================================
FAIL: test_errno_mapping (test.test_exception_hierarchy.HierarchyTest.test_errno_mapping)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Lib/test/test_exception_hierarchy.py", line 94, in test_errno_mapping
    self.assertIs(type(e), OSError)
AssertionError: <class 'PermissionError'> is not <class 'OSError'>
----------------------------------------------------------------------

gvanrossum avatar Aug 16 '22 21:08 gvanrossum

Tho other WASM builds are fine. @tiran what do you think?

gvanrossum avatar Aug 17 '22 01:08 gvanrossum

:robot: New build scheduled with the buildbot fleet by @tiran for commit ef7e7f63a469a40ee480c19688b6f5ae8fc4b2ed :robot:

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot avatar Aug 17 '22 05:08 bedevere-bot

The wasm32-wasi PR build fails with a different error:

It's an unrelated error which is already fixed in main.

tiran avatar Aug 17 '22 07:08 tiran

@serhiy-storchaka: Status check is done, and it's a pending ❌ .

miss-islington avatar Aug 17 '22 08:08 miss-islington

@serhiy-storchaka: Status check is done, and it's a pending ❌ .

miss-islington avatar Aug 17 '22 08:08 miss-islington

Status check is done, and it's a success ✅ .

miss-islington avatar Aug 17 '22 09:08 miss-islington

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. 🐍🍒⛏🤖

miss-islington avatar Aug 17 '22 09:08 miss-islington

Sorry @serhiy-storchaka, I had trouble checking out the 3.11 backport branch. Please backport using cherry_picker on command line. cherry_picker 36517101dd80cae93da379e95e98a688c52935b7 3.11

miss-islington avatar Aug 17 '22 09:08 miss-islington

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. 🐍🍒⛏🤖

miss-islington avatar Aug 17 '22 11:08 miss-islington

GH-96041 is a backport of this pull request to the 3.11 branch.

bedevere-bot avatar Aug 17 '22 11:08 bedevere-bot