cpython
cpython copied to clipboard
gh-95736: Fix event loop creation in IsolatedAsyncioTestCase
It should be created before calling the setUp() method, but after checking for skipping a test.
- Issue: gh-95736
:robot: New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 1194f25ded04a15a1a5ec408ce81178e24125c20 :robot:
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
I have a new ticket and PR GH-96031
Well, this fix sure looks simpler than @tiran's. I'll defer judgment until I've had time to look at things more thoroughly though.
Let's merge this PR to unblock and fix main branch. We can solve https://github.com/python/cpython/issues/95736 and correct the problematic implementation in the async unittest helper later.
The wasm32-wasi PR build fails with a different error:
======================================================================
FAIL: test_errno_mapping (test.test_exception_hierarchy.HierarchyTest.test_errno_mapping)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Lib/test/test_exception_hierarchy.py", line 94, in test_errno_mapping
self.assertIs(type(e), OSError)
AssertionError: <class 'PermissionError'> is not <class 'OSError'>
----------------------------------------------------------------------
Tho other WASM builds are fine. @tiran what do you think?
:robot: New build scheduled with the buildbot fleet by @tiran for commit ef7e7f63a469a40ee480c19688b6f5ae8fc4b2ed :robot:
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
The wasm32-wasi PR build fails with a different error:
It's an unrelated error which is already fixed in main.
@serhiy-storchaka: Status check is done, and it's a pending ❌ .
@serhiy-storchaka: Status check is done, and it's a pending ❌ .
Status check is done, and it's a success ✅ .
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. 🐍🍒⛏🤖
Sorry @serhiy-storchaka, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 36517101dd80cae93da379e95e98a688c52935b7 3.11
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. 🐍🍒⛏🤖
GH-96041 is a backport of this pull request to the 3.11 branch.