python
gh-95601: restore support for awaitable objects that are not futures in `asyncio.wait` and deprecate that support
Looks like there's something worse going on here. It's possible to put a non-duck type future into wait and reach add_done_callback/remove_done_callback maybe a cf.Future can get in here?
FWIW I don't think this should be deferred blocker. cc @pablogsal
If is adding a deprecation, is a blocker because we certainly won't be able to do it after the first release. It still needs an exemption though
FWIW I don't think this should be deferred blocker. cc @pablogsal
If is adding a deprecation, is a blocker because we certainly won't be able to do it after the first release. It still needs an exemption though
this is undoing a removal that didn't go via the deprecation policy, and then applying a deprecation for restored functionality
@tiran recommended spitting this PR into two, one that restores the functionality removed without deprecation and one that does the deprecation.
It seems that the function was always supposed to only support futures and tasks. If you want to add support of arbitrary awaitables, it should be a new feature. And you need to update the documentation, the docstring and error messages to reflect this.
It seems that the function was always supposed to only support futures and tasks. If you want to add support of arbitrary awaitables, it should be a new feature. And you need to update the documentation, the docstring and error messages to reflect this.
that's correct however support for Awaitables is currently available in 3.7, 3.8, 3.9, 3.10 and was removed as a consequence of an incorrectly enforced deprecation in 3.11
I plan to deprecate this support correctly in https://github.com/python/cpython/issues/96783
@serhiy-storchaka can you re-review this? I'll add the warning if you and @tiran agree it should be added in this PR.
My previous reviews should be discarded as the code has changed since I reviewed. (I don't think I have the permission to dismiss stale reviews.). Since 3.11 is final now, it can't be backported either. I am hoping that @gvanrossum and @1st1 can handle this for 3.12.