cpython gh-95389: socketmodule: expose popular `ETHERTYPE

Issue: gh-95389

Jul 28 '22 16:07 noamcohen97

still missing docs, news and tests

Jul 28 '22 16:07 noamcohen97

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Aug 01 '22 11:08 bedevere-bot

I have made the requested changes; please review again.

Aug 01 '22 12:08 noamcohen97

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

Aug 01 '22 12:08 bedevere-bot

FreeBSD seems to have the header file net/ethernet.h, too. The BSD variant uses different constant names like ETHERTYPE_IP. These are also supported by Linux's net/ethernet.h. Could you please check other platforms and use a common subset for the constants?

I know it's a PITB, but Python supports macOS and FreeBSD, too. Any new feature should work on all platforms if possible.