cpython icon indicating copy to clipboard operation
cpython copied to clipboard

bpo-32779: Fix urljoining with an empty query string.

Open thetorpedodog opened this issue 7 years ago • 5 comments

Previously, urllib.urljoin with a relative URL of the form '?' would result in no change to the URL, in spite of the fact that it should clear the query string. This solves that case and variations on it.

https://bugs.python.org/issue32779

thetorpedodog avatar Feb 12 '18 22:02 thetorpedodog

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

the-knights-who-say-ni avatar Feb 12 '18 22:02 the-knights-who-say-ni

Bump—I’ve signed the CLA. How do I get that check rerun?

@the-knights-who-say-ni if i @ you will it do the thing

thetorpedodog avatar Feb 15 '18 00:02 thetorpedodog

Removing reviewers who were added on account of a bad rebase. Sorry!

thetorpedodog avatar May 28 '21 15:05 thetorpedodog

Force pushing to do an update is almost never the right thing to do and too often ruins a PR by bringing in other commits. git merge upstream/main on the PR branch seems to never do this.

Removing the extraneous commits did not removed the reviewer requests, so I did the latter. With the PR back to your commits, I checked the box to run GHA tests so Senthil can see them.

terryjreedy avatar May 28 '21 15:05 terryjreedy

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Aug 15 '22 00:08 github-actions[bot]

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

cpython-cla-bot[bot] avatar Feb 09 '23 08:02 cpython-cla-bot[bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot avatar Apr 21 '23 00:04 bedevere-bot