WIP: bpo-1100942: Add datetime.time.strptime and datetime.date.strptime

[matrixise]

Add datetime.date.strptime and datetime.time.strptime.

Fix the documentation of _strptime._strptime, the documentation was wrong, return a 3-tuple and not a 2-tuple

Co-authored-by: Alexander Belopolsky [email protected] Co-authored-by: Amaury Forgeot d'Arc [email protected] Co-authored-by: Berker Peksag [email protected] Co-authored-by: Josh-sf [email protected] Co-authored-by: Juarez Bochi [email protected] Co-authored-by: Maciej Szulik [email protected] Co-authored-by: Stéphane Wirtel [email protected] Co-authored-by: Matheus Vieira Portela [email protected]

https://bugs.python.org/issue1100942

[matrixise]

This PR is for a very long issue, since 2005. We have a PR in 2018 :+1:

[Mariatta]

I restarted the travis job. It still did not do the full CPython test suite. So please rebase :)

[matrixise]

Thanks, I didn't see your message, works on this issue today.

[matrixise]

@Mariatta rebased and the tests pass on the CIs

[matrixise]

Hi @pganssle

thank you for your review, I am going to fix it asap but I am not the author of the code, just the author of the PR. so, maybe I would need your help. Thanks

[matrixise]

@pganssle I just rebased my branch with master. I am going to work on this PR. Do you want to help me because you are mister dateutil ;-)

[pganssle]

@matrixise Sorry this is on my list but probably can't get to it until the end of the month. 😟

[matrixise]

@pganssle ok, in this case, I will try to fix all the issues alone ;-) but I am not worried ;-)

[matrixise]

Hi, I just updated this PR with master.

[matrixise]

@pganssle when you have time, could you review this PR, we started together, just comment when you find a mistake, thanks

[matrixise]

ping @pganssle ;-)

[matrixise]

@pganssle thanks for your review, I am going to update this PR asap.

[matrixise]

ok, rebased with the last master.

[matrixise]

ok, I will check and try to fix that, but because I don't know this part and the main patch was not mine, that will be difficult.

but okay for the fix. thanks for the review.

[matrixise]

@pganssle Are you ready for a new review of this PR? I will continue my PR ;-)

[pganssle]

@matrixise Yes sorry about that, I will put it on my list for the next few days, possibly this weekend (though I have an event I'm mentoring at that may take a lot of my time).

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[matrixise]

@vstinner I started to rewrite the _check_invalid_datetime_specs in C. I need to refactor date_strptime

[csabella]

@matrixise, @pganssle There's been a lot of work done on this one. Is it something we should try to move forward on? Thanks!

[github-actions[bot]]

This PR is stale because it has been open for 30 days with no activity.

[zitterbewegung]

@matrixise, @pganssle, @csabella while there has been lots of work for this where are we at on this? Its around a bit over two years old for the PR but, these new features would be great!