bpo-40254: Have pyspecific directives translatable

[cocoatomo]

https://bugs.python.org/issue40254

The original issue: https://github.com/python/python-docs-ja/issues/24

The patch provided from tk0miya, the Sphinx main contributor: https://gist.github.com/tk0miya/e2de1962f073d389251ba13e285b4336

https://bugs.python.org/issue40254

[cocoatomo]

Would someone attach the "skip news" label to this PR?

[JulienPalard]

Looking at this (a bit late), would this change also remove the 100+ "Raises an :ref:auditing event..." from the .po files and add a single one with placeholders in sphinx.po?

[cocoatomo]

Excuse me for late. The aim of this PR is the same as the one you supposed.

[JulienPalard]

It's interesting the. I had a totally different approch in https://github.com/python/cpython/pull/24945

I don't remember if my approch works at deduplicating msgids in the po files though, I'm testing.

[JulienPalard]

Hum yes, inded my version still generates tons of:

c-api.pot:msgid "Raises an :ref:`auditing event <auditing>` ``setopencodehook`` with no arguments."
c-api.pot:msgid "Raises an :ref:`auditing event <auditing>` ``cpython._PySys_ClearAuditHooks`` with no arguments."
c-api.pot:msgid "Raises an :ref:`auditing event <auditing>` ``cpython.PyInterpreterState_New`` with no arguments."
c-api.pot:msgid "Raises an :ref:`auditing event <auditing>` ``cpython.PyInterpreterState_Clear`` with no arguments."
using.pot:msgid "Raises an :ref:`auditing event <auditing>` ``cpython.run_command`` with argument ``command``."
using.pot:msgid "Raises an :ref:`auditing event <auditing>` ``cpython.run_module`` with argument ``module-name``."
using.pot:msgid "Raises an :ref:`auditing event <auditing>` ``cpython.run_stdin`` with no arguments."
using.pot:msgid "Raises an :ref:`auditing event <auditing>` ``cpython.run_file`` with argument ``filename``."

so yes this is interesting!! Can you please rebase on top of main?

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@tomo711

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

[JulienPalard]

Damn, my rebase triggered @the-knights-who-say-ni :D

@cocoatomo why the author of the commit is "Tomohiko Kinebuchi"?

[cocoatomo]

Thank you for rebasing! 👍

That name is my official name, and I would miss choosing the account.

[JulienPalard]

I would miss choosing the account

I bet accounts are found using the commiter email, which is the only information available at this stage.

Is kinebuchi at preferred.jp linked to @cocoatomo AND @tomo711?

[cocoatomo]

"cocoatomo" is an account of my private activities, which linked email is "[email protected]". Another account "tomo711" is one used in the company, which linked email is "[email protected]". So, using "tomo711" is my mistake.

[JulienPalard]

@cocoatomo OK I understand now, and was able to fix it using a git commit --amend --autor ....

[JulienPalard]

@cocoatomo It looks OK to me for a merge. I just let you review if I rebased correctly and if I correctly amended the autor attribute, let me know.

[cocoatomo]

Very very thanks!

I will check the codes until tomorrow.

@tk0miya If you can, could you view it?

[JulienPalard]

Hi @cocoatomo! Found this old PR while cleaning my inbox, looks like we forgot it :D

[JulienPalard]

@cocoatomo @tk0miya gentle ping.

[humitos]

We found this error again when upgrading the Spanish translation to 3.11. Besides that, a new error for availability has arrived because of this line https://github.com/python/cpython/blob/b3cafb60afeb2300002af9982d43703435b8302d/Doc/tools/extensions/pyspecific.py#L146 cc @JulienPalard

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[humitos]

It would be good to be able to include this PR in 3.12 -- this will help a lot the work of the translators 😄

[AA-Turner]

Nobody expects the Spanish Inquisition!

edit: Bedevere has been gotten by the Spanish Inquisition...

[miss-islington]

Thanks @cocoatomo for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. 🐍🍒⛏🤖

[bedevere-bot]

GH-107681 is a backport of this pull request to the 3.12 branch.

[bedevere-bot]

GH-107682 is a backport of this pull request to the 3.11 branch.