cpython icon indicating copy to clipboard operation
cpython copied to clipboard

bpo-30514: test_pop3lib asyncore with asyncio

Open grzgrzgrz3 opened this issue 8 years ago • 7 comments

Pop3 server stub was base on asyncore/asynchat which is deprecated, new stub is using asyncio instead.

test_too_long_lines make sure we read remaining overlong response

cmd_user answer only with +ERR message on invalid user

#74699

grzgrzgrz3 avatar May 30 '17 17:05 grzgrzgrz3

@grzgrzgrz3, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @serhiy-storchaka and @giampaolo to be potential reviewers.

mention-bot avatar May 30 '17 17:05 mention-bot

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9c972b5). Click here to learn what that means. The diff coverage is 97.67%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1864   +/-   ##
=========================================
  Coverage          ?   82.68%           
=========================================
  Files             ?     1432           
  Lines             ?   353405           
  Branches          ?        0           
=========================================
  Hits              ?   292229           
  Misses            ?    61176           
  Partials          ?        0
Impacted Files Coverage Δ
Lib/test/test_poplib.py 98.13% <97.67%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c972b5...996e0cc. Read the comment docs.

codecov[bot] avatar May 30 '17 19:05 codecov[bot]

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Feb 19 '22 00:02 github-actions[bot]

I'll work on getting this up to date so it unblocks removing asyncore. Note to self: local branch name is bpo30514-grzegorz-grzywacz-poplib.

JelleZijlstra avatar May 10 '22 15:05 JelleZijlstra

Triggering CLA.

AA-Turner avatar Jun 07 '22 14:06 AA-Turner

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Jul 08 '22 00:07 github-actions[bot]

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Nov 10 '22 00:11 github-actions[bot]

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Dec 14 '22 00:12 github-actions[bot]