cpython
cpython copied to clipboard
Published
1 week ago
•
python
python
gh-139757: Add BINARY_OP_SUBSCR_USTR_INT
Since https://github.com/python/cpython/pull/140800 BINARY_OP_SUBSCR_STR_INT only specializes for compact ASCII strings. Let's introduce BINARY_OP_SUBSCR_USTR_INT to specialize again for reading an ASCII character from any string.
- Issue: gh-139757
I verified a 9% speedup on this PR for the tomli_loads benchmark on pyperformance:
Mean +- std dev: [spec_off] 2.24 sec +- 0.03 sec -> [spec_on] 2.05 sec +- 0.02 sec: 1.09x faster
Apparently, we regressed earlier in https://github.com/python/cpython/pull/140800/files. This caused the 10% slowdown in tomli loads. Which seemingly uses a lot of unicode strings.
I'm going to merge this PR to remove the perf regression.
Sorry for leaving 3 separate review comments instead of one review. I only picked up on some of these while looking over them again.
:warning::warning::warning: Buildbot failure :warning::warning::warning:
Hi! The buildbot ARM64 macOS 3.x (tier-2) has failed when building commit e6bfe4d8869e046a91d091611d3c7b5dccdaf0d6.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/725/builds/12456) and take a look at the build logs.
- Check if the failure is related to this commit (e6bfe4d8869e046a91d091611d3c7b5dccdaf0d6) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/#/builders/725/builds/12456
Failed tests:
- test_urllib2net
Summary of the results of the build (if available):
==
Click to see traceback logs
remote: Enumerating objects: 54, done.
remote: Counting objects: 1% (1/54)
remote: Counting objects: 3% (2/54)
remote: Counting objects: 5% (3/54)
remote: Counting objects: 7% (4/54)
remote: Counting objects: 9% (5/54)
remote: Counting objects: 11% (6/54)
remote: Counting objects: 12% (7/54)
remote: Counting objects: 14% (8/54)
remote: Counting objects: 16% (9/54)
remote: Counting objects: 18% (10/54)
remote: Counting objects: 20% (11/54)
remote: Counting objects: 22% (12/54)
remote: Counting objects: 24% (13/54)
remote: Counting objects: 25% (14/54)
remote: Counting objects: 27% (15/54)
remote: Counting objects: 29% (16/54)
remote: Counting objects: 31% (17/54)
remote: Counting objects: 33% (18/54)
remote: Counting objects: 35% (19/54)
remote: Counting objects: 37% (20/54)
remote: Counting objects: 38% (21/54)
remote: Counting objects: 40% (22/54)
remote: Counting objects: 42% (23/54)
remote: Counting objects: 44% (24/54)
remote: Counting objects: 46% (25/54)
remote: Counting objects: 48% (26/54)
remote: Counting objects: 50% (27/54)
remote: Counting objects: 51% (28/54)
remote: Counting objects: 53% (29/54)
remote: Counting objects: 55% (30/54)
remote: Counting objects: 57% (31/54)
remote: Counting objects: 59% (32/54)
remote: Counting objects: 61% (33/54)
remote: Counting objects: 62% (34/54)
remote: Counting objects: 64% (35/54)
remote: Counting objects: 66% (36/54)
remote: Counting objects: 68% (37/54)
remote: Counting objects: 70% (38/54)
remote: Counting objects: 72% (39/54)
remote: Counting objects: 74% (40/54)
remote: Counting objects: 75% (41/54)
remote: Counting objects: 77% (42/54)
remote: Counting objects: 79% (43/54)
remote: Counting objects: 81% (44/54)
remote: Counting objects: 83% (45/54)
remote: Counting objects: 85% (46/54)
remote: Counting objects: 87% (47/54)
remote: Counting objects: 88% (48/54)
remote: Counting objects: 90% (49/54)
remote: Counting objects: 92% (50/54)
remote: Counting objects: 94% (51/54)
remote: Counting objects: 96% (52/54)
remote: Counting objects: 98% (53/54)
remote: Counting objects: 100% (54/54)
remote: Counting objects: 100% (54/54), done.
remote: Compressing objects: 3% (1/27)
remote: Compressing objects: 7% (2/27)
remote: Compressing objects: 11% (3/27)
remote: Compressing objects: 14% (4/27)
remote: Compressing objects: 18% (5/27)
remote: Compressing objects: 22% (6/27)
remote: Compressing objects: 25% (7/27)
remote: Compressing objects: 29% (8/27)
remote: Compressing objects: 33% (9/27)
remote: Compressing objects: 37% (10/27)
remote: Compressing objects: 40% (11/27)
remote: Compressing objects: 44% (12/27)
remote: Compressing objects: 48% (13/27)
remote: Compressing objects: 51% (14/27)
remote: Compressing objects: 55% (15/27)
remote: Compressing objects: 59% (16/27)
remote: Compressing objects: 62% (17/27)
remote: Compressing objects: 66% (18/27)
remote: Compressing objects: 70% (19/27)
remote: Compressing objects: 74% (20/27)
remote: Compressing objects: 77% (21/27)
remote: Compressing objects: 81% (22/27)
remote: Compressing objects: 85% (23/27)
remote: Compressing objects: 88% (24/27)
remote: Compressing objects: 92% (25/27)
remote: Compressing objects: 96% (26/27)
remote: Compressing objects: 100% (27/27)
remote: Compressing objects: 100% (27/27), done.
remote: Total 28 (delta 26), reused 2 (delta 1), pack-reused 0 (from 0)
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to 'e6bfe4d8869e046a91d091611d3c7b5dccdaf0d6'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at e6bfe4d8869 gh-139757: Add BINARY_OP_SUBSCR_USTR_INT (GH-143389)
Switched to and reset branch 'main'
make: *** [buildbottest] Error 2
