python
gh-137716: TracebackException to handle messages with punctuation
Added extra handling for error messages with punctuation to avoid double punctuations and eliminated code duplication
- Issue: gh-137716
![python-cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/1203010?v=4 "Published by a pub.dev verified publisher"){kind=small}
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
![bedevere-app[bot] avatar](https://avatars.githubusercontent.com/in/388350?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm still unusure about whether to rstrip() or not. I said "no" for now but it could be helpful. On one's hand, if a (custom) exception message ends with a new line for readability purposes, it would be better not to add the punctuation as well and use a fresh new line.
I have made the requested changes; please review again
Thank you for reconsideration of the proposed refactor. I think we can safely consider exception messages ending with a new line out of scope for this use case.
Thanks for making the requested changes!
: please review the changes made to this pull request.
This PR contains several unrelated changes, please revert all of these.
I thought so but I think it's necessary (the changes are a simple refactorization to simplify the handling). As for the blank lines being removed, we can revert them or keep them.
EDIT: NVM, it's the merge commit that messed up the review. @krisztian-gajdar Please avoid force-pushing, it makes incremental review harder.
NVM, it's the merge commit that messed up the review. @krisztian-gajdar Please avoid force-pushing, it makes incremental review harder.
Yep, fixed. sorry for the inconvenience.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
And if you don't make the requested changes, you will be put in the comfy chair!
Thanks for making the requested changes!
@AA-Turner: please review the changes made to this pull request.
@picnixz I have added test covering all for cases for the puctuation
Thanks for making the requested changes!
@AA-Turner: please review the changes made to this pull request.
@picnixz, @AA-Turner Is there anything else I should do?
Just checking in, let me know if I can help move this forward 🙏
Thanks for making the requested changes!
: please review the changes made to this pull request.
Thank you @picnixz for the approve. @AA-Turner what are the next steps?
@AA-Turner conflicts have been resolved, please proceed with the merge. 🙏
please proceed with the merge. 🙏
I still have outstanding review comments above, please let me know if it's been resolved.
A
All of them has been resolved as I see, please let me know if it's not the case.
Thank you. In the future, please add a comment after each review suggestion noting if/how it has been resolved.
A