cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-137696: Rename 'fort' parameter to 'order' in PyBuffer_* functions

Open CarlosEduR opened this issue 4 months ago • 7 comments

This PR updates the PyBuffer_FromContiguous function by renaming the fort parameter to order for clarity. The function's declaration in the header already uses order; this change updates all references in the implementation and documentation to match.

It also updates the declaration of the PyBuffer_IsContiguous function in the header by renaming fort to order. Its documentation and definition were already using order as the parameter name.

  • Issue: gh-137696

📚 Documentation preview 📚: https://cpython-previews--137866.org.readthedocs.build/

CarlosEduR avatar Aug 16 '25 17:08 CarlosEduR

All commit authors signed the Contributor License Agreement.

CLA signed

python-cla-bot[bot] avatar Aug 16 '25 17:08 python-cla-bot[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar Aug 16 '25 17:08 bedevere-app[bot]

Please see https://github.com/python/cpython/issues/137696#issuecomment-3197359092 and change the functions (declarations and definitions) as well as the documentation so that all of them use 'order' instead of a mix of all. In addition, please sign the CLA.

picnixz avatar Aug 18 '25 15:08 picnixz

Please see #137696 (comment)

Thanks for the review, @picnixz. The functions and documentation have been updated.

CarlosEduR avatar Aug 18 '25 22:08 CarlosEduR

Let's push this forward @CarlosEduR @picnixz

nybblista avatar Aug 26 '25 17:08 nybblista

Let's push this forward @CarlosEduR @picnixz

Can you review it again, @picnixz? I just merged main into this branch again to keep it up to date.

CarlosEduR avatar Aug 26 '25 19:08 CarlosEduR

Thanks for the review, @picnixz

CarlosEduR avatar Jan 05 '26 19:01 CarlosEduR