cpython icon indicating copy to clipboard operation
cpython copied to clipboard

Doc: Fix all duplicate words

Open LamentXU123 opened this issue 5 months ago • 5 comments

I am translating doc recently. I've noticed that there are duplicate words in every corner of cpython.

This PR fixes all duplicate words I've found in the current main branch. I think I've fixed it all ;)

Summary here:

multiply multiply -> multiply (this is the most important one caz it exists in the example code) is is -> is the the -> the ~that that -> that~ that that -> that the Update update -> Update Idb idb -> Idb and and -> and to to -> to should should -> should should should -> should it it -> it is the the -> the and and -> and

Skipping issues and news.


📚 Documentation preview 📚: https://cpython-previews--136086.org.readthedocs.build/

LamentXU123 avatar Jun 29 '25 04:06 LamentXU123

I am not sure whether I'm going to change the autoconf file here, since it couldn't pass the test.

LamentXU123 avatar Jun 29 '25 05:06 LamentXU123

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Jun 29 '25 05:06 bedevere-app[bot]

The test failure I cannot fix is this:

Me too.

An alternative is to make a separate PR for idlelib.

Edited: Well yes. I think this alternative could make sure the doc change of idle are not effected by others. I will open one now.

LamentXU123 avatar Jun 29 '25 05:06 LamentXU123

An alternative is to make a separate PR for idlelib and stop if backports of the other changes fails.

I've opened it at #136089 and delete the changes in this PR.

LamentXU123 avatar Jun 29 '25 05:06 LamentXU123

So should we remove the change of autoconf file here? I still have no idea of how to deal with it.

LamentXU123 avatar Jun 29 '25 12:06 LamentXU123

The autoconf change is a typo on GNU's end. It's visible here too: https://www.gnu.org/software/autoconf-archive/ax_c_float_words_bigendian.html. Let's remove it from this PR, and then you can submit a fix to their mailing list or whatever they use.

ZeroIntensity avatar Jun 29 '25 13:06 ZeroIntensity

The autoconf change is a typo on GNU's end. It's visible here too: https://www.gnu.org/software/autoconf-archive/ax_c_float_words_bigendian.html. Let's remove it from this PR, and then you can submit a fix to their mailing list or whatever they use.

I will submit the issue through [email protected], and will raise another PR when they accept it(if they don't then I will not)

Let's remove it first here.

Done.

LamentXU123 avatar Jun 29 '25 13:06 LamentXU123

Thanks @LamentXU123 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jun 29 '25 22:06 miss-islington-app[bot]

GH-136108 is a backport of this pull request to the 3.14 branch.

bedevere-app[bot] avatar Jun 29 '25 22:06 bedevere-app[bot]

Thanks @LamentXU123 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jun 29 '25 22:06 miss-islington-app[bot]

Sorry, @LamentXU123 and @terryjreedy, I could not cleanly backport this to 3.13 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker 698bab5a4031c8f54e04e1dd42bcbe3e4564eba5 3.13

miss-islington-app[bot] avatar Jun 29 '25 22:06 miss-islington-app[bot]

:warning::warning::warning: Buildbot failure :warning::warning::warning:

Hi! The buildbot aarch64 Fedora Stable Refleaks 3.x (tier-2) has failed when building commit 698bab5a4031c8f54e04e1dd42bcbe3e4564eba5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/123/builds/1343) and take a look at the build logs.
  4. Check if the failure is related to this commit (698bab5a4031c8f54e04e1dd42bcbe3e4564eba5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/123/builds/1343

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 373, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 799 events and lost 2[34 chars]\n\n' != ''
- Warning:
- Processed 799 events and lost 2 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 373, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 627 events and lost 3[34 chars]\n\n' != ''
- Warning:
- Processed 627 events and lost 3 chunks!
- 
- Check IO/CPU overload!
- 

bedevere-bot avatar Jun 29 '25 23:06 bedevere-bot

Looks like the expected backport failure happens...... I'll take a look at this this evening.

LamentXU123 avatar Jun 30 '25 00:06 LamentXU123

The 3.14 backport was merged. AFAIK, there is no 3.13 backport, which is fine.

terryjreedy avatar Jul 25 '25 23:07 terryjreedy

GH-137357 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Aug 03 '25 20:08 bedevere-app[bot]