cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-81520: Add documentatoion about unexpected os.path.ismount() behaviour

Open bionade24 opened this issue 6 months ago • 2 comments

2 PRs, one adds documentation about the false positives with btrfs subvolumes & the 2nd about adding the unexpected behaviour to the docstring, so that it also shows up in pydoc

  • Issue: gh-81520

📚 Documentation preview 📚: https://cpython-previews--136058.org.readthedocs.build/

bionade24 avatar Jun 28 '25 06:06 bionade24

All commit authors signed the Contributor License Agreement.

CLA signed

python-cla-bot[bot] avatar Jun 28 '25 06:06 python-cla-bot[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar Jun 28 '25 06:06 bedevere-app[bot]

To be honest, I'm not sure we need to clarify this for other similar fs like zfs.

Zheaoli avatar Jul 04 '25 15:07 Zheaoli

To be honest, I'm not sure we need to clarify this for other similar fs like zfs.

What do you want to tell? This PR has nothing to do with ZFS and I don't know how os.path.ismount() behaves on it.

bionade24 avatar Jul 08 '25 05:07 bionade24

Rebased it on main. Anything else that I need to do?

bionade24 avatar Jul 08 '25 05:07 bionade24

FWIW, you don't need to force-push. We squash at the end anyway, and it just makes reviewing a little more difficult.

ZeroIntensity avatar Jul 09 '25 15:07 ZeroIntensity

Thanks @bionade24 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jul 09 '25 15:07 miss-islington-app[bot]

GH-136471 is a backport of this pull request to the 3.14 branch.

bedevere-app[bot] avatar Jul 09 '25 15:07 bedevere-app[bot]

GH-136473 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Jul 09 '25 15:07 bedevere-app[bot]

Congrats on your first contribution :)

ZeroIntensity avatar Jul 09 '25 15:07 ZeroIntensity