cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-125887: Update PyObject_HasAttr exception behavior

Open Damien-Chen opened this issue 1 year ago • 3 comments

Resolve #125887

  • Issue: gh-125887

📚 Documentation preview 📚: https://cpython-previews--125907.org.readthedocs.build/

Damien-Chen avatar Oct 24 '24 00:10 Damien-Chen

@Damien-Chen, please avoid force-pushes.

skirpichev avatar Oct 24 '24 13:10 skirpichev

I want to rebase and squash my commit, but --force push seems necessary.

Damien-Chen avatar Oct 24 '24 13:10 Damien-Chen

Please avoid also rebase, etc. Just add new commits - all going to be squashed in a single commit on merge anyway.

FYI: https://devguide.python.org/getting-started/pull-request-lifecycle/#lifecycle-of-a-pull-request

skirpichev avatar Oct 24 '24 14:10 skirpichev

Thanks @Damien-Chen for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Dec 27 '24 01:12 miss-islington-app[bot]

GH-128283 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Dec 27 '24 01:12 bedevere-app[bot]