cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-119538: Add missing build dependencies

Open Meiye-lj opened this issue 1 year ago • 6 comments

This PR fixes an issue in the Makefile.pre.in of Cpython. Specifically, previously, any modifications of files like Objects/mimalloc/alloc-override.c would not trigger a rebuild of Objects/obmalloc.o. The PR fixes this by including them as additional dependencies. This addresses https://github.com/python/cpython/pull/120096 and https://github.com/python/cpython/issues/119538. https://github.com/python/cpython/issues/119538 and https://github.com/python/cpython/pull/119647 resolve some missing dependency errors, this PR further fixes missing dependency errors.

  • Issue: gh-119538

Meiye-lj avatar Oct 13 '24 07:10 Meiye-lj

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar Oct 13 '24 07:10 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar Oct 13 '24 07:10 bedevere-app[bot]

Please add the gh-<issue_id> prefix to the title.

Edit

gh-120096: Fixing missing build dependencies in Makefile.pre.in

rruuaanng avatar Oct 13 '24 10:10 rruuaanng

Hmmmm, You may need to open an issue. Then, you should explain why the previous PR was closed.

rruuaanng avatar Oct 13 '24 10:10 rruuaanng

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar Oct 14 '24 00:10 bedevere-app[bot]

Arranged in order, It looks good! Maybe you can try to arrange them in alphabetical order. (a,b,...)

Edit: Sorry, It may not be very detailed. I mean, Maybe arranged according to the initials of the file:).

rruuaanng avatar Oct 15 '24 07:10 rruuaanng

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Oct 25 '24 21:10 bedevere-app[bot]