cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-122767: document "new style" formatting for complexes

Open skirpichev opened this issue 1 year ago • 7 comments

  • Issue: gh-122767

📚 Documentation preview 📚: https://cpython-previews--122848.org.readthedocs.build/

skirpichev avatar Aug 09 '24 05:08 skirpichev

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Aug 24 '24 14:08 bedevere-app[bot]

I have made the requested changes; please review again.

skirpichev avatar Aug 24 '24 14:08 skirpichev

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

bedevere-app[bot] avatar Aug 24 '24 14:08 bedevere-app[bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

bedevere-app[bot] avatar Sep 01 '24 07:09 bedevere-app[bot]

I have made the requested changes; please review again.

skirpichev avatar Sep 01 '24 07:09 skirpichev

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

bedevere-app[bot] avatar Sep 01 '24 07:09 bedevere-app[bot]

CC @ericvsmith, are you waiting for the second opinion? (BTW, I'm ok above suggestion by @picnixz)

skirpichev avatar Oct 24 '24 07:10 skirpichev

Thanks @skirpichev for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Oct 29 '24 14:10 miss-islington-app[bot]

GH-126128 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Oct 29 '24 14:10 bedevere-app[bot]

GH-126129 is a backport of this pull request to the 3.12 branch.

bedevere-app[bot] avatar Oct 29 '24 14:10 bedevere-app[bot]