cpython
cpython copied to clipboard
[3.14] Raise DeprecationWarnings (GH-121604)
This fixes #121604.
- importlib.abc.ResourceLoader
- importlib.abc.SourceLoader.path_mtime()
- importlib.machinery.DEBUG_BYTECODE_SUFFIXES
- importlib.machinery.OPTIMIZED_BYTECODE_SUFFIXES
- importlib.machinery.WindowsRegistryFinder
- importlib.machinery.SourcelessFileLoader
The others defined in the issue can be considered already done.
Issue: https://github.com/python/cpython/issues/121604
- Issue: gh-121604
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.
If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
@tomasr8 thanks for the review, I made some changes.
FYI this PR breaks the test suite, so CI isn't passing.
Hi @rashansmith! Looks like this PR hasn't had any activity in a while, would you like to continue working on it?
Hello @rashansmith if you do not have the time to complete this I can take on the project.
Hello @rashansmith if you do not have the time to complete this I can take on the project.
Hey! Thanks for volunteering @StanFromIreland, but I'm already working on finishing this PR :/ If you still want to help with this though, I'd appreciate your review! I'll send the updated PR tomorrow :slightly_smiling_face:
This MR is currently adding deprecation warnings to importlib.abc.Loader, importlib.machinery.SourcelessFileLoader, and importlib.abc.InspectLoader, but none of those are currently documented as being deprecated; just the load_module method for each.
Hello everyone, thanks for taking this on. It was my first attempt at a PR in this repo so I'm looking forward to seeing how the work here is done and hopefully I can contribute to more work in the future!
Thanks @rashansmith for your work! I'm giving you credit in the followup PR :)
I'll close this now since it's superseded by https://github.com/python/cpython/pull/128007