cpython icon indicating copy to clipboard operation
cpython copied to clipboard

[3.14] Raise DeprecationWarnings (GH-121604)

Open rashansmith opened this issue 1 year ago • 3 comments

This fixes #121604.

The others defined in the issue can be considered already done.

Issue: https://github.com/python/cpython/issues/121604

  • Issue: gh-121604

rashansmith avatar Jul 14 '24 11:07 rashansmith

All commit authors signed the Contributor License Agreement.
CLA signed

ghost avatar Jul 14 '24 11:07 ghost

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar Jul 14 '24 11:07 bedevere-app[bot]

@tomasr8 thanks for the review, I made some changes.

rashansmith avatar Jul 14 '24 13:07 rashansmith

FYI this PR breaks the test suite, so CI isn't passing.

brettcannon avatar Sep 26 '24 17:09 brettcannon

Hi @rashansmith! Looks like this PR hasn't had any activity in a while, would you like to continue working on it?

tomasr8 avatar Nov 26 '24 21:11 tomasr8

Hello @rashansmith if you do not have the time to complete this I can take on the project.

StanFromIreland avatar Dec 15 '24 21:12 StanFromIreland

Hello @rashansmith if you do not have the time to complete this I can take on the project.

Hey! Thanks for volunteering @StanFromIreland, but I'm already working on finishing this PR :/ If you still want to help with this though, I'd appreciate your review! I'll send the updated PR tomorrow :slightly_smiling_face:

tomasr8 avatar Dec 15 '24 21:12 tomasr8

This MR is currently adding deprecation warnings to importlib.abc.Loader, importlib.machinery.SourcelessFileLoader, and importlib.abc.InspectLoader, but none of those are currently documented as being deprecated; just the load_module method for each.

tungol avatar Dec 16 '24 18:12 tungol

Hello everyone, thanks for taking this on. It was my first attempt at a PR in this repo so I'm looking forward to seeing how the work here is done and hopefully I can contribute to more work in the future!

rashansmith avatar Dec 16 '24 21:12 rashansmith

Thanks @rashansmith for your work! I'm giving you credit in the followup PR :)

I'll close this now since it's superseded by https://github.com/python/cpython/pull/128007

tomasr8 avatar Dec 18 '24 13:12 tomasr8