cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-59022: Added tests for `pkgutil.extend_path` (#59022)

Open beachmachine opened this issue 1 year ago • 3 comments

This adds tests for the documented behaviour of pkgutil.extend_path regarding different argument types as well as for *.pkg files.

I took inspiration from the PR #12871 for the tests I've added. However, some of those tests did not seem to make sense to me, so I've ended up with the two test-cases in this PR.

  • Issue: gh-59022

beachmachine avatar Jul 13 '24 10:07 beachmachine

All commit authors signed the Contributor License Agreement.
CLA signed

ghost avatar Jul 13 '24 10:07 ghost

Thanks! Just one more issue :)

For the future: please avoid force-pushing to CPython PRs; it makes them harder to review. Just add additional commits. The PR will be squashed when it's merged.

encukou avatar Jul 14 '24 09:07 encukou

Thanks! Just one more issue :)

For the future: please avoid force-pushing to CPython PRs; it makes them harder to review. Just add additional commits. The PR will be squashed when it's merged.

Thanks for the hint. I will not use force-push for future CPython PRs.

Also, the comment in the test is removed now, so this PR is ready to be reviewed again.

beachmachine avatar Jul 14 '24 11:07 beachmachine

Thank you!

encukou avatar Jul 16 '24 15:07 encukou

Thanks @beachmachine for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jul 16 '24 15:07 miss-islington-app[bot]

Thanks @beachmachine for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jul 16 '24 15:07 miss-islington-app[bot]

Thanks @beachmachine for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jul 18 '24 08:07 miss-islington-app[bot]

Thanks @beachmachine for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jul 18 '24 08:07 miss-islington-app[bot]

GH-121950 is a backport of this pull request to the 3.12 branch.

bedevere-app[bot] avatar Jul 18 '24 08:07 bedevere-app[bot]

GH-121951 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Jul 18 '24 08:07 bedevere-app[bot]