cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-121359: make clean environment (no PYTHON* vars) for test_pyrepl.TestMain

Open skirpichev opened this issue 1 year ago • 5 comments

  • Issue: gh-121359

skirpichev avatar Jul 13 '24 09:07 skirpichev

I think this can skip news;)

skirpichev avatar Jul 13 '24 09:07 skirpichev

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Jul 13 '24 13:07 bedevere-app[bot]

I have made the requested changes; please review again

skirpichev avatar Jul 13 '24 15:07 skirpichev

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

bedevere-app[bot] avatar Jul 13 '24 15:07 bedevere-app[bot]

test_pyrepl passes after applying the PR to an up-to-date main branch.

smontanaro avatar Jul 14 '24 01:07 smontanaro

Thanks @skirpichev for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jul 15 '24 19:07 miss-islington-app[bot]

GH-121810 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Jul 15 '24 19:07 bedevere-app[bot]