cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-121160: Note that readline libraries using different history formats.

Open encukou opened this issue 1 year ago • 1 comments

This is not something we can do too much about, without help from the underlying libraries.

The file formats seem to be treated as implementation details, hidden behind API calls.

  • Issue: gh-121160

📚 Documentation preview 📚: https://cpython-previews--121327.org.readthedocs.build/

encukou avatar Jul 03 '24 11:07 encukou

@Yhg1s, you're the readline expert. Does this look good?

encukou avatar Jul 04 '24 12:07 encukou

I'll merge next week.

encukou avatar Jul 19 '24 11:07 encukou

Eehh, "expert"... But yeah, I think this is the only thing we can do here.

Yhg1s avatar Jul 19 '24 12:07 Yhg1s

Thanks!

Expert just means you've signed up for notifications about tricky or controversial changes :)

encukou avatar Jul 19 '24 13:07 encukou

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jul 19 '24 13:07 miss-islington-app[bot]

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. 🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app[bot] avatar Jul 19 '24 13:07 miss-islington-app[bot]

Sorry, @encukou, I could not cleanly backport this to 3.12 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker 709db44255eb5d73fc22a1341dd0253e71ddfda9 3.12

miss-islington-app[bot] avatar Jul 19 '24 13:07 miss-islington-app[bot]

GH-122030 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Jul 19 '24 13:07 bedevere-app[bot]

GH-122031 is a backport of this pull request to the 3.12 branch.

bedevere-app[bot] avatar Jul 19 '24 14:07 bedevere-app[bot]