cpython icon indicating copy to clipboard operation
cpython copied to clipboard

No documentation for sqlite3.Binary

Open jonathan-geoseer opened this issue 1 year ago • 4 comments

https://docs.python.org/3/library/sqlite3.html - does not have any documentation for sqlite3.Binary() method

jonathan-geoseer avatar May 01 '24 10:05 jonathan-geoseer

Binary() is a part of PEP-249; see https://peps.python.org/pep-0249/#binary

Note that the other PEP-249 constructors are not documented either:

  • Date()
  • Time()
  • Timestamp()
  • DateFromTicks()
  • TimeFromTicks()
  • TimestampFromTicks()

erlend-aasland avatar May 01 '24 21:05 erlend-aasland

Hello,

A bit of background: I've been learning programming for a few years now. I developed and keep developing projects of my own using mainly shell, C and Python (hosted in gitlab). I want to become an active contributor in the FOSS ecosystem, and I believe Python would be a good place to start. So I searched issues with an 'easy' tag and found this one. I'm familiar with reST and SQL at a beginner level, and I'm learning sqlite3 for my own projects. I set up my development environment as directed in the devguide, built python and its documentation, and ran all the tests.

Now back to the issue at hand: I looked at PEP-249, the documentation for sqlite and its module, and found Lib/sqlite3/dbapi2.py. However, I don't know where to go from here. I'm eager to learn and would be glad if given directions.

Thank you for your time.

firat-v avatar May 03 '24 12:05 firat-v

I'm eager to learn and would be glad if given directions.

Great; first, take a look at the devguide section for documentation:

  • https://devguide.python.org/documentation/

I also encourage taking a look at our documentation north star, Diátaxis: https://diataxis.fr

The missing documentation should be added to the file Doc/library/sqlite3.rst in the CPython repo. IMO, the missing constructors should be documented under the Module functions header (between line 259 and line 425 in Doc/library/sqlite3.rst). I suggest to add them at the end of that section.

Shout out if you need more info :)

erlend-aasland avatar May 07 '24 08:05 erlend-aasland

Thank you :) Now I have a clear map in my head and explored most of it. Started implementing. I'll have a pull request by Monday.

firat-v avatar May 11 '24 22:05 firat-v