cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-116303: Handle disabled test modules in test.support

Open erlend-aasland opened this issue 1 year ago • 2 comments

Yak shave for gh-116303

erlend-aasland avatar Mar 07 '24 23:03 erlend-aasland

(the hypothesis failure has its own issue: #116455)

erlend-aasland avatar Mar 10 '24 11:03 erlend-aasland

For the Windows failures, see:

  • #116458
  • #116467

Marking this as a draft until #116458 has landed.

erlend-aasland avatar Mar 10 '24 11:03 erlend-aasland

Marking this as a draft until https://github.com/python/cpython/pull/116458 has landed.

This fix has landed in the main branch.

vstinner avatar Mar 22 '24 14:03 vstinner

LGTM.

Thanks, but we cannot merge this; the Windows ~~free-threaded~~ builds still fail :(

  • https://github.com/python/cpython/actions/runs/8458383758/job/23172507933?pr=116482

erlend-aasland avatar Mar 27 '24 20:03 erlend-aasland

@vstinner, would you like to review the updated PR?

erlend-aasland avatar Mar 28 '24 07:03 erlend-aasland

Overall, it's kind of strange to ask (1) to not build tests and (2) to run tests :-)

More specifically, they are asking to not build test extension modules, but still be able to run the test suite. I think it is a legitimate thing to ask :)

erlend-aasland avatar Mar 28 '24 08:03 erlend-aasland

Thanks for the reviews; I'm enabling auto-merge.

erlend-aasland avatar Mar 28 '24 08:03 erlend-aasland

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Mar 28 '24 08:03 miss-islington-app[bot]

Sorry, @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker 6c8ac8a32fd6de1960526561c44bc5603fab0f3e 3.12

miss-islington-app[bot] avatar Mar 28 '24 08:03 miss-islington-app[bot]

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker 6c8ac8a32fd6de1960526561c44bc5603fab0f3e 3.11

miss-islington-app[bot] avatar Mar 28 '24 08:03 miss-islington-app[bot]

I'm not so sure about backporting this anymore.

erlend-aasland avatar Mar 28 '24 10:03 erlend-aasland

The main reason to backport test changes is to make future backports easier. If there are already conflicts, I wouldn't feel bad about not backporting.

encukou avatar Mar 28 '24 11:03 encukou