cpython icon indicating copy to clipboard operation
cpython copied to clipboard
Published 4 days ago • verified publisher icon python

gh-111673: Refactor test_float/complex.py (split out support classes)

Open skirpichev opened this issue 2 years ago • 4 comments

First commit mostly taken from #26827, second - some simple extension of this. @serhiy-storchaka

  • Issue: gh-111673

skirpichev avatar Oct 17 '23 04:10 skirpichev

@AlexWaygood, does this require news? I think - not.

skirpichev avatar Nov 04 '23 03:11 skirpichev

@AlexWaygood, does this require news? I think - not.

Yeah, we can skip it for this one, good call

AlexWaygood avatar Nov 04 '23 05:11 AlexWaygood

Will wait #111996

skirpichev avatar Dec 03 '23 02:12 skirpichev

@sobolevn, maybe you can review this as an issue author? Let me know if it's better to split this to several pull requests.

skirpichev avatar Jul 04 '24 05:07 skirpichev

CC @vstinner

skirpichev avatar Apr 17 '25 07:04 skirpichev

I already proposed something similar in #84310. But it only defined classes with a single special method (__index__, __float__), which could be used in a number of tests. I am not sure that it is worth to share simple or too specialized classes like IntSubclass or WithIntAndIndex.

serhiy-storchaka avatar Apr 17 '25 14:04 serhiy-storchaka

Ok, thanks.

I think, I haven't enough motivation to push it further.

skirpichev avatar Apr 17 '25 23:04 skirpichev