core-workflow icon indicating copy to clipboard operation
core-workflow copied to clipboard
verified publisher icon python

Generate notifications if PRs are merged without review

Open erlend-aasland opened this issue 1 year ago • 3 comments

Suggesting to create a new Discord channel #github-push-without-review and enhance the bot(s) to generate posts for PRs that are merged without review.

erlend-aasland avatar Jun 10 '24 07:06 erlend-aasland

Related ideas[^1]:

  • generate notifications for PRs that touch code (tests excluded?) and are labelled with skip-issue
  • generate notifications for PRs with large diffs (generated files excluded)

[^1]: we can create separate issues for these if they seem interesting enough

erlend-aasland avatar Jun 10 '24 08:06 erlend-aasland

Closing, stale.

AA-Turner avatar Aug 12 '25 03:08 AA-Turner

I still think we should consider this. I can help move this forward, but I need someone to help me get started with bot hacking.

erlend-aasland avatar Sep 18 '25 14:09 erlend-aasland

I think you need to

  • create the channel manually
  • get into some admin dashboard to create a webhook configured to post into that channel
  • send a POST request with a message: https://github.com/python/buildmaster-config/pull/535/files#diff-2cd6017ac3282602901e72065afa3899460144408f623174861b6f5ea66e2db5R66-R82

(I know there used to be a discord python library to make this easier (and support markup and other rich content) but last I heard about it, it was difficult to maintain it because of discord’s actions hostile to third-party automations.)

merwok avatar Nov 18 '25 15:11 merwok

yep, discord supports webhooks. ideal for this.

gpshead avatar Nov 19 '25 06:11 gpshead