core-workflow icon indicating copy to clipboard operation
core-workflow copied to clipboard
verified publisher icon python

Should the Tests / Ubuntu (pull_request) not be required on 3.8/3.9 branches?

Open Mariatta opened this issue 5 years ago • 3 comments

There are a couple PRs that I noticed (there might be more) where automerging was blocked, because it was waiting for the required check: Tests / Ubuntu (pull_request) to pass. Looking at these PRs, it appeared that the Tests / Ubuntu (pull_request) were both Skipped on that branch.

https://github.com/python/cpython/pull/22869 [3.8] https://github.com/python/cpython/pull/22897 [3.9]

Should this check not be required on the 3.9, 3.8 branches?

Todo:

  • [ ] Adjust miss-islington to handle skipped tests, instead of expecting all success status

Mariatta avatar Oct 29 '20 18:10 Mariatta

@ambv what's your opinion?

brettcannon avatar Oct 29 '20 19:10 brettcannon

This is a bug. The tests are required and I'd prefer it stayed that way. Backports are not always a trivial manner, unrelated commits that were not backported could sometimes be required for a change to work correctly.

The bug is that for changes which don't touch code at all we skip running tests whatsoever and this somehow blocks auto-merging. It shouldn't if the step was skipped.

ambv avatar Oct 29 '20 22:10 ambv

Ok I will need to adjust miss-islington to understand that some tests can be skipped. Currently it expects all success status.

Mariatta avatar Oct 29 '20 23:10 Mariatta