core-workflow icon indicating copy to clipboard operation
core-workflow copied to clipboard

Spellcheck PRs before merge.

Open terryjreedy opened this issue 6 years ago • 1 comments

In spite of previous spelling fixes over the years, there have been, I recall, at least 3 spell fix PRs over the last several months. The problem is that we keep committing patches that add new doubled words and misspellings. For #6374, Guido, who does not like the code churn, said "Ideally spell checks would run on PRs.".

I presume people preparing the patches are using some combination of of python with re and some linux facility. I have no idea how many false positives such people have to ignore.

A separate issue is whether passing a spell check should be opt in or opt out.

terryjreedy avatar Apr 20 '18 20:04 terryjreedy

For my part, I've been using https://github.com/client9/misspell with decent results, as well as some local greps.

scop avatar May 04 '18 19:05 scop