cherry-picker icon indicating copy to clipboard operation
cherry-picker copied to clipboard

Allow passing a base branch that doesn't have version info

Open Jackenmen opened this issue 3 years ago • 7 comments

Resolves #69

I could add enforcement of something here if this is too lax but I'm not sure what kind of check that could be. I suppose I could also add an option to .cherry_picker.toml that needs to be explicitly enabled to allow passing non-version branches if that makes it any better.

I'm aware this issue wasn't accepted but I kinda felt like doing it anyway, even if it doesn't end up merged :P

Jackenmen avatar Jul 10 '22 20:07 Jackenmen

I think this change is reasonable.

Mariatta avatar Oct 04 '22 00:10 Mariatta

Tests are currently failing on main and so this PR is affected, I fixed them in #76.

Jackenmen avatar Oct 04 '22 10:10 Jackenmen

I think allowing it to be configured via the toml file is a good idea as well. Would you be able to add that in a separate PR?

Mariatta avatar Oct 04 '22 22:10 Mariatta

I can do it here or in a separate PR, whatever you prefer. Can probably get to it tomorrow.

I assume you would want this to be a true/false setting determining whether branches without version info are allowed (defaulting to false to keep the current behavior intact)?

Jackenmen avatar Oct 04 '22 22:10 Jackenmen

I think it should support the original behavior if not supplied.

Mariatta avatar Oct 04 '22 23:10 Mariatta

Alright, I added a require_version_in_branch_name option. Quite a mouthful but I couldn't really come up with anything else that was still clear about what the option is. At most I could maybe manage to make the name 4-5 characters shorter but the names I came up with were, in my opinion, a lot more vague than the current name.


While looking into this, I also realized that I suggested adding such an option in the PR's description which I didn't really realize when you asked me to add it :smile:

Jackenmen avatar Oct 05 '22 16:10 Jackenmen

I created https://github.com/python/miss-islington/pull/639 to make miss-islington work with this PR since I realized that this is going to be necessary now that this also adds a new configuration option.

Jackenmen avatar Aug 27 '23 23:08 Jackenmen