asyncio icon indicating copy to clipboard operation
asyncio copied to clipboard

Review SSL handling

Open GoogleCodeExporter opened this issue 10 years ago • 6 comments

There are a couple of XXX comments in the SSL socket transport that deserve 
more attention; more so now I've implemented pause()/resume(). See this thread:

https://groups.google.com/forum/#!topic/python-tulip/1ih4FKvdUuI



Original issue reported on code.google.com by [email protected] on 1 Oct 2013 at 8:25

GoogleCodeExporter avatar Apr 10 '15 16:04 GoogleCodeExporter

Original comment by [email protected] on 16 Oct 2013 at 4:36

  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

GoogleCodeExporter avatar Apr 10 '15 16:04 GoogleCodeExporter

Original comment by [email protected] on 19 Oct 2013 at 12:11

  • Changed state: WontFix

GoogleCodeExporter avatar Apr 10 '15 16:04 GoogleCodeExporter

Actually, Nikolay just reported that the SSL transport uses 100% CPU time when 
using HTTPS long-polling. Clearly there's an issue here and my original 
intuition (that I was doing it wrong) was right. Goal: fix this before CPython 
3.4 beta 1.

Original comment by [email protected] on 22 Oct 2013 at 4:55

  • Changed state: Accepted
  • Added labels: Priority-High
  • Removed labels: Priority-Low

GoogleCodeExporter avatar Apr 10 '15 16:04 GoogleCodeExporter

(A patch is under review at https://codereview.appspot.com/16620043/ )

Original comment by [email protected] on 30 Oct 2013 at 9:12

GoogleCodeExporter avatar Apr 10 '15 16:04 GoogleCodeExporter

ssl transport has been refactored in b3185e98afd5
but someone should review 'eof_recevied' part.

Original comment by [email protected] on 31 Oct 2013 at 6:39

GoogleCodeExporter avatar Apr 10 '15 16:04 GoogleCodeExporter

FYI A "new" SSL implementation based on ssl.MemoryBIO is under review:
http://bugs.python.org/issue22560

It doesn't change all SSL code, but it's a very large change.

Original comment by [email protected] on 9 Jan 2015 at 8:59

GoogleCodeExporter avatar Apr 10 '15 16:04 GoogleCodeExporter