asyncio
asyncio copied to clipboard
python
Ensure correct sockets family in create_connection and create_server
create_unix_server() and create_unix_connection() should only accept UNIX
sockets
create_server() and create_connection() should only accept AF_INET and AF_INET6
sockets.
Link to code review: http://codereview.appspot.com/65180044
Original issue reported on code.google.com by [email protected] on 19 Feb 2014 at 5:16
As I just said in the code review, I think we shouldn't do this (or not YET)
but we should document the requirement.
Original comment by [email protected] on 19 Feb 2014 at 3:52
Considering that 'create_unix_server' already has this check (committed with
the main UNIX support patch), can I at least add this check to
'create_unix_connection'?
Original comment by [email protected] on 19 Feb 2014 at 4:04
No. Learn to live with the consequences of small mistakes.
I really want to reduce the torrent of patches. Please help review the docs,
Victor has had very little help so far!
Original comment by [email protected] on 19 Feb 2014 at 4:06
> I really want to reduce the torrent of patches. Please help review the docs,
Victor has had very little help so far!
Hi, Yury wrote his patch while we were in the hurry of the Python 3.4.0
release. It was one year ago.
Guido: can you reconsider your opinion on Yury's change? Checking the socket
family when a socket object is passed looks correct, but I didn't review the
change yet.
Original comment by [email protected] on 9 Jan 2015 at 3:49