feat(core): Add support for Container and TTL nodes

[ceache]

Also add support through transations.

Closes #334, #496

[ceache]

Still missing tests. Will need to update the harness to configure Zookeeper to enable extended types.

[jeffwidman]

@ceache just curious on the status here? I assume you've just been busy? Or have you abandoned this for some reason and forgot to close it?

[ceache]

Well, I have been incredibly busy, sorry about that. But not idle.

I have implemented a Wireshark zookeeper protocol dissector (I'll link it here) and confirmed the issue is indeed in zookeeper.

https://issues.apache.org/jira/browse/ZOOKEEPER-4026

The PR is otherwise not wrong, albeit it needs a little tidy up before merge. But I am not sure how to go about testing it. (be permissive?)

On Sun, Dec 13, 2020, 15:31 Jeff Widman [email protected] wrote:

@ceache https://github.com/ceache just curious on the status here? I assume you've just been busy? Or have you abandoned this for some reason and forgot to close it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/python-zk/kazoo/pull/613#issuecomment-744064138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIFTHXSXLUP4ZCHTQODJDLSUUQAPANCNFSM4N7HORNQ .

[jeffwidman]

Haha, I also have been working on a Wireshark zookeeper dissector the last few months in my spare time as a way to learn C/wiresharp APIs/understand the ZK protocol at a deeper level: https://gitlab.com/wireshark/wireshark/-/merge_requests/528

I've had to put it on hold the last few weeks as we somewhat spontaneously decided to buy a house so I've been busy with that, but hope to pick it back up during my time off over the holidays.

I would say for testing, being permissive is fine with me. I'm also completely fine with letting this sit for a bit longer to get a ZK release with the bugfix if that makes testing this simpler... whatever you prefer/think is wisest. It would be nice to have a test, but I defer to your judgement. I just wanted a status update since there'd been no update since June.

[ceache]

Mine is a LUA dissector https://github.com/ceache/zab_dissector

[Traktormaster]

Hi!

In short I've found myself in the need for nodes with TTL. I'm not entirely sure how this PR is blocked, but I figured it might be good enough for me. I've forked, merged it in and added a simple test to check if persistent TTL nodes behave as expected. They work great as far as I can tell. You can find it here: https://github.com/Traktormaster/kazoo/tree/ttlme

I'm not sure how to offer that commit into this PR myself, but you may find it useful when getting back to work on this.

Thanks!

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 60.60606% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 93.58%. Comparing base (2fb93a8) to head (69a3271). Report is 2 commits behind head on master.

:exclamation: Current head 69a3271 differs from pull request most recent head db886ae. Consider uploading reports for the commit db886ae to get more accurate results

Files	Patch %	Lines
kazoo/protocol/serialization.py	40.42%	28 Missing :warning:
kazoo/client.py	78.84%	11 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   96.81%   93.58%   -3.24%     
==========================================
  Files          27       57      +30     
  Lines        3549     8418    +4869     
==========================================
+ Hits         3436     7878    +4442     
- Misses        113      540     +427     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[j-smith-1574]

Hello,

is there any updates on the release of this PR?