python-zeroconf icon indicating copy to clipboard operation
python-zeroconf copied to clipboard

Enable building of arm64 macOS builds

Open devbanu opened this issue 1 year ago • 0 comments
trafficstars

This PR is related to issues #1376 and #1380.

Enabling building for macOS arm64 builds is simple, because the newest macOS runners build in arm64 by default. Hence the addition of macos-latest to the matrix.

Also, since macos-11 runners are deprecated (see [1]), switched to macos-12 for the x86_64 builds.

Incidentally, it seems current Ubuntu runners don't include apt-get by default, so switched to using apt command.

So to summarize:

  • macos-12 runners will continue building macOS x86_64 builds
  • macos-latest runners will now build macOS arm64 builds

The new files look like this:

  zeroconf-0.132.2-cp310-cp310-macosx_14_0_arm64.whl          4,683 kB
  zeroconf-0.132.2-cp311-cp311-macosx_14_0_arm64.whl          4,685 kB
  zeroconf-0.132.2-cp312-cp312-macosx_14_0_arm64.whl          4,704 kB
  zeroconf-0.132.2-cp39-cp39-macosx_14_0_arm64.whl            1,727 kB
  zeroconf-0.132.2-pp310-pypy310_pp73-macosx_14_0_arm64.whl   4,428 kB
  zeroconf-0.132.2-pp38-pypy38_pp73-macosx_14_0_arm64.whl     4,423 kB
  zeroconf-0.132.2-pp39-pypy39_pp73-macosx_14_0_arm64.whl     4,425 kB

Note that it seems impossible to build cp38 for arm64 so excluded that configuration, while pp38 seems fine.

Unrelated, but it seem all wheels after cp39 include .c source code in them, making the wheels larger. This should probably addressed in a separate PR.

[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

devbanu avatar Jul 09 '24 14:07 devbanu