folium icon indicating copy to clipboard operation
folium copied to clipboard

Example Notebooks Not Accessible

Open jmpmcmanus opened this issue 1 year ago • 3 comments

Describe the bug I've been trying to access the example notebooks, but when I do I get the following message:

We've updated our documentation. You can find the new version of this notebook here: https://python-visualization.github.io/folium/latest/user_guide/plugins/marker_cluster.html

When I try and access the URL the site cannot be reached. I clone the repo and tried it from my own machine, but have the same problem.

To Reproduce

https://python-visualization.github.io/folium/latest/user_guide/plugins/marker_cluster.html

Expected behavior The notebook should be accessible, but get a "This site can’t be reached" error. In the URL is references a "latest" directory, that does not exist in the repo.

Environment (please complete the following information):

  • Browser This problem exists in both the Chrome and Firefox browsers.
  • Jupyter Notebook example files are not accessible. The directory "latest" does not exist in the repo.

Possible solutions Add the directory "latest" to the repo, with the revised notebooks.

folium is maintained by volunteers. Can you help making a fix for this issue?

jmpmcmanus avatar Oct 18 '23 13:10 jmpmcmanus

Hi @jmpmcmanus, thanks for the report, but I don’t really understand the issue. We have deprecated the notebooks and instead incorporated the content in our documentation. That url works fine for me. But do note it’s not a notebook, but a GitHub Pages webpage.

Does that url work for you if you open it in your browser?

Conengmo avatar Oct 18 '23 16:10 Conengmo

I see the relationship between the old notebooks and the user_guide now. The bad links confused me.

The URL listed for the MarkerCluster.ipynb notebook:

https://python-visualization.github.io/folium/latest/user_guide/plugins/marker_cluster.html

is the user_guide doc:

https://github.com/python-visualization/folium/blob/main/docs/user_guide/plugins/marker_cluster.md

So I will start using the user guide docs.

Thanks! Jim

jmpmcmanus avatar Oct 18 '23 16:10 jmpmcmanus

I see, glad it’s clear now.

I think this also means we should update the deprecation message in the example notebooks to be more clear. To include something that their content got moved to the documentation. And remove the part that indicates the notebook just got moved.

Let’s keep this issue open to remind of that.

Thanks for letting us know Jim!

Conengmo avatar Oct 19 '23 07:10 Conengmo