branca icon indicating copy to clipboard operation
branca copied to clipboard

Feature request: Option to change color of legend's text

Open gcaria opened this issue 1 year ago • 3 comments

This comes from https://github.com/geopandas/geopandas/issues/2897, since geopandas.GeoDataFrame.explore() uses branca:

I wish I could plot a colormap also on tiles where dense forests have dark colors, but I can't read the colorbar's title and ticks since they are written with a black font.

gcaria avatar May 22 '23 19:05 gcaria

Sounds like a good change to have, to be able to style the legend text. Shouldn’t be too complicated. I’m thinking we could:

  • add a parameter to hard-code white or black text color
  • add a parameter to add any inline CSS
  • add a parameter to add a CSS class, so users can define CSS for the legend text elsewhere

I’m inclined to opt for 2. at the moment but I’m open for other opinions.

Help is welcome to work in this!

Conengmo avatar May 23 '23 06:05 Conengmo

Related issue that proposes a background on colormaps: https://github.com/python-visualization/branca/issues/124

Conengmo avatar May 23 '23 06:05 Conengmo

I made a PR (#160) to resolve the issue, although it only allows SVG Recognised Colors, rather than arbitrary inline CSS like @Conengmo recommended.

I believe that should be sufficient for @gcaria's requirements, and to enable the resolving of geopandas/geopands#2897.

This is my first open-source contribution, so feel free to give any advice or tips :)

ThomasBur avatar Mar 29 '24 08:03 ThomasBur

Since https://github.com/python-visualization/branca/pull/160 was merged we can close this issue.

Conengmo avatar Jun 14 '24 17:06 Conengmo