trustme
trustme copied to clipboard
expose `not_before` and `not_after` cert validity params

Codecov Report
Merging #455 (4cfd43e) into master (6728e36) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #455 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1169 1253 +84
Branches 46 52 +6
=========================================
+ Hits 1169 1253 +84
Impacted Files | Coverage Δ | |
---|---|---|
trustme/__init__.py | 100.00% <100.00%> (ø) |
|
trustme/_cli.py | 100.00% <100.00%> (ø) |
|
trustme/tests/test_cli.py | 100.00% <0.00%> (ø) |
|
trustme/tests/test_trustme.py | 100.00% <0.00%> (ø) |
|
a/trustme/trustme/tests/test_cli.py | 100.00% <0.00%> (ø) |
|
a/trustme/trustme/tests/test_trustme.py | 100.00% <0.00%> (ø) |
|
...sers/runner/work/trustme/trustme/tests/test_cli.py | 100.00% <0.00%> (ø) |
|
.../runner/work/trustme/trustme/tests/test_trustme.py | 100.00% <0.00%> (ø) |
HI! Thanks for the polished contribution. We'll also need to improve the docs and add a changelog.
However, what is the use case for setting not_before
/not_after
for the root CA?
Closing for now as I did not get an answer to my questions above.