trio icon indicating copy to clipboard operation
trio copied to clipboard

Allow documentation builds on Windows

Open A5rocks opened this issue 10 months ago • 4 comments

Fixes https://github.com/python-trio/trio/issues/3071

I'm not totally sure about all changes here. Some are likely only because my local installation of Python is 3.13.

Also this is definitely not the cleanest method of doing this :P

A5rocks avatar Mar 20 '25 21:03 A5rocks

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 100.00000%. Comparing base (efd785a) to head (03a78ca). :warning: Report is 83 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3227   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             127          127           
  Lines           19257        19266    +9     
  Branches         1301         1303    +2     
===============================================
+ Hits            19257        19266    +9     
Files with missing lines Coverage Δ
src/trio/_channel.py 100.00000% <ø> (ø)
src/trio/_core/__init__.py 100.00000% <100.00000%> (ø)
src/trio/_core/_run.py 100.00000% <ø> (ø)
src/trio/_highlevel_socket.py 100.00000% <100.00000%> (ø)
src/trio/_path.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_unix_pipes.py 100.00000% <ø> (ø)
src/trio/_timeouts.py 100.00000% <ø> (ø)
src/trio/_unix_pipes.py 100.00000% <ø> (ø)
src/trio/lowlevel.py 100.00000% <100.00000%> (ø)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 20 '25 21:03 codecov[bot]

Makes sense to me. I've always just ignored the FDStream error in logs when building, since I didn't need to test that bit.

TeamSpen210 avatar Mar 20 '25 22:03 TeamSpen210

I'm not totally sure about all changes here. Some are likely only because my local installation of Python is 3.13.

you can test this with tox -e docs, ~~though you'll either need to manually modify the base_python variable between runs or change the definition to [testenv:py{39,310,311,312,313}-docs]~~

Or rather, .readthedocs.yml and the docs environment both specify 3.11, so you don't need to verify on any other versions. We might want to bump from 311 to 313 though

jakkdl avatar Jun 05 '25 13:06 jakkdl

so you don't need to verify on any other versions

Yeah, I don't remember what I was thinking when writing that initial comment (probably was just because I wasn't sure RTD would pass...)

A5rocks avatar Jun 06 '25 03:06 A5rocks

Are there any issues with this? I'd like to merge this otherwise.

A5rocks avatar Jun 27 '25 00:06 A5rocks