Fix `TaskStatus.started()` being a no-op when in an effectively cancelled scope

[gschaffner]

proposed patch and tests to fix #2895 and close #2544.

[codecov[bot]]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a10f94b) 99.68% compared to head (651b51a) 99.57%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2896      +/-   ##
==========================================
- Coverage   99.68%   99.57%   -0.11%     
==========================================
  Files         117      117              
  Lines       17546    17579      +33     
  Branches     3152     3161       +9     
==========================================
+ Hits        17490    17505      +15     
- Misses         38       50      +12     
- Partials       18       24       +6     

Files	Coverage Δ
src/trio/_core/_run.py	99.77% <ø> (-0.23%)	:arrow_down:
src/trio/_core/_tests/test_run.py	99.88% <97.77%> (-0.12%)	:arrow_down:

... and 2 files with indirect coverage changes

[njsmith]

This is a subtle bit of design, so let's give the issue discussions more time to converge before merging anything.

On Sat, Dec 2, 2023 at 6:26 AM codecov[bot] @.***> wrote:

Codecov https://app.codecov.io/gh/python-trio/trio/pull/2896?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio Report

Merging #2896 https://app.codecov.io/gh/python-trio/trio/pull/2896?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio (b038de5 https://github.com/python-trio/trio/commit/b038de53950cc023fbee580bde2e2ba50cf2ad97) into master https://app.codecov.io/gh/python-trio/trio/commit/783093f812e750981b3c6e8b3fb3351717f75d40?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio (783093f https://github.com/python-trio/trio/commit/783093f812e750981b3c6e8b3fb3351717f75d40) will decrease coverage by 18.54%. The diff coverage is 97.77%.

Additional details and impacted files

@@ Coverage Diff @@## master #2896 +/- ## ===========================================- Coverage 99.54% 81.00% -18.54%

Files 115 115 Lines 17663 17651 -12 Branches 3158 1392 -1766 ===========================================- Hits 17583 14299 -3284 - Misses 52 3250 +3198 - Partials 28 102 +74

Files https://app.codecov.io/gh/python-trio/trio/pull/2896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio Coverage Δ src/trio/_core/_run.py https://app.codecov.io/gh/python-trio/trio/pull/2896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio#diff-c3JjL3RyaW8vX2NvcmUvX3J1bi5weQ== 98.64% <ø> (-1.36%) ⬇️ src/trio/_core/_tests/test_run.py https://app.codecov.io/gh/python-trio/trio/pull/2896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio#diff-c3JjL3RyaW8vX2NvcmUvX3Rlc3RzL3Rlc3RfcnVuLnB5 99.82% <97.77%> (-0.18%) ⬇️

... and 59 files with indirect coverage changes https://app.codecov.io/gh/python-trio/trio/pull/2896/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-trio

— Reply to this email directly, view it on GitHub https://github.com/python-trio/trio/pull/2896#issuecomment-1837160863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEU42DOK7CO4Y3A5IEESXDYHM3BRAVCNFSM6AAAAABAEBQF26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGE3DAOBWGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Nathaniel J. Smith -- https://vorpus.org http://vorpus.org