trio icon indicating copy to clipboard operation
trio copied to clipboard

implement StapledMemoryChannel

Open belm0 opened this issue 5 years ago • 5 comments

partially addresses #719

belm0 avatar Nov 01 '20 11:11 belm0

Codecov Report

Merging #1784 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1784   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         114      114           
  Lines       14453    14486   +33     
  Branches     1105     1106    +1     
=======================================
+ Hits        14401    14434   +33     
  Misses         37       37           
  Partials       15       15           
Impacted Files Coverage Δ
trio/__init__.py 100.00% <ø> (ø)
trio/_channel.py 100.00% <100.00%> (ø)
trio/tests/test_channel.py 100.00% <100.00%> (ø)

codecov[bot] avatar Nov 01 '20 23:11 codecov[bot]

It looks like codecov was down when you submitted that pull request. Closing/reopening

pquentin avatar Nov 02 '20 07:11 pquentin

@belm0 Codecov now complains about aclose() not being tested

pquentin avatar Nov 02 '20 08:11 pquentin

3.9.0-rc2 stalled when installing dependencies, closing/reopening...

pquentin avatar Nov 02 '20 12:11 pquentin

@njsmith please take a look

I started with StapledMemoryChannel rather than StapledChannel, since my use case is needing the nowait methods. Not sure whether it's worth making a MemoryChannel abc.

belm0 avatar Nov 06 '20 01:11 belm0