trio icon indicating copy to clipboard operation
trio copied to clipboard

Issue #1246 change docs to sigterm

Open jmfrank63 opened this issue 5 years ago • 6 comments

Small change, hope this is what is wanted.

Closes #1246

jmfrank63 avatar Oct 31 '19 17:10 jmfrank63

Codecov Report

Merging #1281 (4d46a6f) into master (8b15548) will not change coverage. The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1281   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         115      115           
  Lines       17514    17514           
  Branches     3125     3125           
=======================================
  Hits        17368    17368           
  Misses        101      101           
  Partials       45       45           
Files Coverage Δ
trio/_signals.py 100.00% <ø> (ø)

codecov[bot] avatar Oct 31 '19 17:10 codecov[bot]

@jmfrank63 Thank you for tackling this! Unfortunately, your pull request contains ~70 unrelated commits. Can you try applying your changes on top of master instead? If you need git help please ask in the chat or here.

pquentin avatar Oct 31 '19 18:10 pquentin

@pquentin Arrgh! How did this happen? Anyway I tried to fix it but it is incredibly hard. Best to open a new PR?

jmfrank63 avatar Oct 31 '19 18:10 jmfrank63

Thanks for fixing the git issue!

I edited the first message so that when we merge this, the corresponding issue is closed.

I think there are two typos (send -> sent and windows -> Windows), but other than that I don't feel I know enough here to properly review your change.

pquentin avatar Nov 02 '19 05:11 pquentin

@jmfrank63 Is there anything we can help with?

pquentin avatar Feb 06 '20 07:02 pquentin

pre-commit.ci autofix

CoolCat467 avatar Oct 27 '23 02:10 CoolCat467