exceptiongroup icon indicating copy to clipboard operation
exceptiongroup copied to clipboard

Added tests from trio's multierror test suite

Open agronholm opened this issue 6 years ago • 4 comments
trafficstars

agronholm avatar Jun 01 '19 16:06 agronholm

Travis tests are failing due to a new pytest warning about unrecognized marks :-(

Could you undo the rename of _teststests? It makes the diff harder to read, and _tests is a better name anyway. (I know Trio still uses tests, but at some point we'll fix it: https://github.com/python-trio/trio/issues/274)

Can you say a few words about how you adapted these from trio? Did they need many changes for the "v2" model?

njsmith avatar Jun 02 '19 08:06 njsmith

Could you undo the rename of _tests → tests? It makes the diff harder to read, and _tests is a better name anyway. (I know Trio still uses tests, but at some point we'll fix it: python-trio/trio#274)

The only reason I did this was because otherwise conftest.py will not get read by pytest. I assumed this was the reason why trio also had its tests directory named tests and not _tests. Personally I am dead set against putting the tests inside the actual packages, and even more so against installing them along with the main code. But as they say: in Rome, do as romans do.

agronholm avatar Jun 02 '19 16:06 agronholm

The leftover problem that prevents the tests from passing on py3.6+ is the one about hashable exceptions. I will continue to investigate it and will report back here.

agronholm avatar Jun 02 '19 20:06 agronholm

Note to self: add fix from https://github.com/python-trio/trio/pull/1023 to resolve the hashability issue.

agronholm avatar Jun 02 '19 21:06 agronholm