social-core icon indicating copy to clipboard operation
social-core copied to clipboard

add uffd oauth2 backend

Open davidc opened this issue 2 years ago • 3 comments

Proposed changes

Adds a new backend to support uffd single sign on - https://git.cccv.de/uffd/uffd

As there are multiple uffd installations, the base URL is configured through config not code.

Types of changes

Please check the type of change your PR introduces:

  • [ ] Release (new release request)
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Code style update (PEP8, lint, formatting, renaming, etc)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Build related changes (build process, tests runner, etc)
  • [ ] Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works

Other information

davidc avatar Mar 24 '22 11:03 davidc

Can you please add tests?

nijel avatar Mar 24 '22 13:03 nijel

Can you please add tests?

I'm not really sure how I can do that since uffd instances are private

davidc avatar Mar 24 '22 15:03 davidc

The testing doesn't happen against real service, the responses are mocked. It does mostly test processing of user data, see for example https://github.com/python-social-auth/social-core/blob/master/social_core/tests/backends/test_coinbase.py

nijel avatar Mar 29 '22 07:03 nijel