rope icon indicating copy to clipboard operation
rope copied to clipboard

Autoimport autodetection

Open bagel897 opened this issue 2 years ago • 6 comments

Motivation

Say you have a large environment with a package (IE: Pytorch) that you mark as a dependency. While you plan to use pytorch, its dependents consume a lot of unnessecary space. Additionally, it doesn't make sense to directly import those packages (since it breaks abstraction).

Description

Autodetects dependencies This makes autoimport much much faster (1.33 sec vs 0.28 sec on a large env) Pyproject.toml support Will deprecate setting underlined per-function/directly w/o going through prefs (feedback?)

Checklist (delete if not relevant):

  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have updated CHANGELOG.md
  • [x] I have made corresponding changes to user documentation for new features
  • [x] I have made corresponding changes to library documentation for API changes

bagel897 avatar Nov 03 '22 16:11 bagel897

@bagel897 other than Database versioning, is there any other things that this PR will need to resolve before this draft PR is "ready for review"?

lieryan avatar Nov 29 '22 00:11 lieryan

I'm going to be very sporadic on all PRs, sorry. I want to deprecate the underlined setting and make it specified in toml but am unsure of the logistics - we need a way to recreate dbs with new settings and versioning and remove all the existing arguments to functions. It might be too ambitious for little gain, though

bagel897 avatar Nov 29 '22 06:11 bagel897

No worries, if you are not already working on it, I might pick the task for that database schema versioning so the DB versioning probably should have its own ticket.

lieryan avatar Nov 29 '22 10:11 lieryan

I'll move the remaining stuff to future PRs

bagel897 avatar Dec 06 '22 18:12 bagel897

@lieryan Sorry for the miscommunication - this PR should be ready. Update: Never Mind, I'll fix this later

bagel897 avatar Apr 18 '23 05:04 bagel897

@lieryan I finally got this one ready, thoughts?

bagel897 avatar Jan 09 '24 19:01 bagel897