poetry icon indicating copy to clipboard operation
poetry copied to clipboard

feat(config)!: change virtualenvs.prefer-active-python default to true

Open finswimmer opened this issue 1 year ago • 4 comments

virtualenvs.prefer-active-python was introduced in 1.2 and works well since than. So there is no need to call it "experimental" any longer (even if there might be space for some improvements).

finswimmer avatar Oct 20 '24 11:10 finswimmer

I was actually considering if we could remove that option or invert it so that one can choose to use system Python instead of the active one. That seems more instinctive behaviour than what we have currently

Secrus avatar Oct 20 '24 12:10 Secrus

I was actually considering if we could remove that option or invert it

I wouldn't remove it, but inverting the default would be fine (But I'm biased here, because that's the config I change first in an new installation ;)

finswimmer avatar Oct 20 '24 12:10 finswimmer

Well, we could take advantage of the fact that we are making a breaking release and change that to use-system-python that would force usage of the Python version Poetry was installed with. That would give us an open interface to introduce findpython backend without breaking changes but as an alternative (until deemed stable).

Secrus avatar Oct 20 '24 17:10 Secrus

I'm fine with renaming, but I think use-system-python is confusing for the users. While it is consistent with the code base, I guess most users would expect that the Python of their system is meant. Maybe use-application-python or use-poetry-python?

finswimmer avatar Oct 20 '24 18:10 finswimmer

I'm fine with renaming, but I think use-system-python is confusing for the users. While it is consistent with the code base, I guess most users would expect that the Python of their system is meant. Maybe use-application-python or use-poetry-python?

I am fine with use-poetry-python and a proper docs entry explaining that.

Secrus avatar Oct 25 '24 09:10 Secrus

Deploy preview for website ready!

✅ Preview https://website-fcx6j3foz-python-poetry.vercel.app

Built with commit a57ee6cbb9c3a5aa2039270c39f0a4ba0ba33845. This pull request is being automatically deployed with vercel-action

github-actions[bot] avatar Oct 27 '24 09:10 github-actions[bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Nov 27 '24 00:11 github-actions[bot]