poetry icon indicating copy to clipboard operation
poetry copied to clipboard

Apply new repo-review suggestion

Open DimitriPapadopoulos opened this issue 1 year ago • 0 comments

RF003: src directory doesn't need to be specified anymore (0.6+)

Ruff now (0.6+) looks in the src directory by default. The src setting doesn't need to be specified if it's just set to ["src"].

https://learn.scientific-python.org/development/guides/repo-review/?repo=python-poetry%2Fpoetry&branch=main

CAVEAT: Removing src = ["src"] results in changes related to the I rules, as suggested by the 0.6.0 release announcement;

By default, our isort rules now search inside src/ directories when determining the list of package names that are likely to represent first-party code. This was always configurable, but it was suprising for many users that Ruff didn't understand this common project structure "out of the box".

This change may result in some of your imports being reordered or recategorised, as import statements that these rules previously considered to be third-party imports will now be correctly understood as first-party.

Pull Request Check List

  • [ ] Added tests for changed code.
  • [ ] Updated documentation for changed code.

DimitriPapadopoulos avatar Aug 24 '24 14:08 DimitriPapadopoulos